Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change directory to cwd before running git user setup. #161

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

bicknellr
Copy link
Contributor

This PR applies cwd before setting the git user name and email. Without this change, the git setup commands are run in $GITHUB_WORKSPACE, which will fail if $GITHUB_WORKSPACE is not a git repo.

Fixes #159.

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2022

🦋 Changeset detected

Latest commit: 3c76349

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/action Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -0,0 +1,5 @@
---
"@changesets/action": patch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to point out I've marked this as 'patch'.

.changeset/old-socks-unite.md Outdated Show resolved Hide resolved
@Andarist Andarist merged commit 52c9ce7 into changesets:main Mar 15, 2022
@github-actions github-actions bot mentioned this pull request Mar 15, 2022
@bicknellr bicknellr deleted the cwd-before-git-setup branch March 15, 2022 17:05
bicknellr added a commit to lit/lit that referenced this pull request Mar 15, 2022
This should no longer be necessary as of `changesets/action@v1.2.2`, which
includes <changesets/action#161>.
bicknellr added a commit to lit/lit that referenced this pull request Apr 13, 2022
* Remove the empty root repo in the release workflow. (...)

This should no longer be necessary as of `changesets/action@v1.2.2`, which
includes <changesets/action#161>.

* Set `setupGitUser: false` on `changesets/action`.

* Add a comment for `setupGitUser: false`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git user setup fails unless the workspace root directory is also a git repo.
2 participants